Pass runningProject to GetUpdateAsync and get projectToRebuild and projectToRestart back
#75503
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
Community
| @@ -92,7 +92,7 @@ | |||
| <!-- | |||
| Subset of Microsoft.VisualStudio.Sdk meta-package (run `csi generate-vssdk-versions.csx` to update based on VSSDK meta-package). | |||
| --> | |||
| <PackageVersion Include="Microsoft.ServiceHub.Framework" Version="4.5.31" /> | |||
| <PackageVersion Include="Microsoft.ServiceHub.Framework" Version="4.5.35" /> | |||
There was a problem hiding this comment.
Shouldn't be updated without updating Microsoft.VisualStudio.SDK. Probably better to bump Microsoft.VisualStudio.SDK in a separate PR.
There was a problem hiding this comment.
How to determine the right VS SDK version to use. I saw the current version is 17.10.234-preview.1 but that one is not available on nuget.org?
src/EditorFeatures/Core/EditAndContinue/EditAndContinueLanguageService.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core/EditAndContinue/EditAndContinueLanguageService.cs
Show resolved
Hide resolved
| @@ -74,6 +74,127 @@ internal ImmutableArray<ManagedHotReloadDiagnostic> GetAllDiagnostics() | |||
|
|
|||
| return builder.ToImmutableAndClear(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Not sure why this is shown as added. Did you rebase against the latest main?
There was a problem hiding this comment.
Not quite follow, what you mean here
There was a problem hiding this comment.
Looks like the code was copied from https://github.com/dotnet/roslyn/pull/75503/files#diff-95af090e3bc672c6352c9245c5b43e6d1561613fc81afee422e462dc9f17a49fR266.
There was a problem hiding this comment.
Yeah that's true, would be better to find out a way to clean it up
src/EditorFeatures/Core/EditAndContinue/EditAndContinueLanguageService.cs
Outdated
Show resolved
Hide resolved
LittleLittleCloud
changed the title
runningProject to GetUpdateAsync and get projectToRebuild and projectToRestart backrunningProject to GetUpdateAsync and get projectToRebuild and projectToRestart back
src/EditorFeatures/Core/EditAndContinue/EditAndContinueLanguageService.cs
Show resolved
Hide resolved
cc @tmat
Work item
Other associated PRs